Sorted Set Decimal Support

Kitura / Kitura-redis

Swift Redis library

Apache License 2.0

94 stars 25 forks source link

Sorted Set Decimal Support #78

Closed scuml closed 3 years ago

scuml commented 4 years ago

Description

Adds double support for sorted sets. Adds WITHSCORES parameter for ZRANGE

Motivation and Context

Sorted sets will use doubles (for microsecond timestamps and popularity algorithms for example). This adds support for doubles, while retaining integer support for backward-compatibility.

A withscores: parameter was also added to ZRANGE. It existed on ZREVRANGE, but previously was not carried over.

How Has This Been Tested?

A unit test test_ZAddFloat has been added to the test suite. This, and code that uses integer scores have both been tested.

Checklist:

[X] I have submitted a CLA form
[x] If applicable, I have updated the documentation accordingly.
[X] If applicable, I have added tests to cover my changes.

CLAassistant commented 4 years ago

All committers have signed the CLA.

mbarnach commented 3 years ago

Thanks for your PR. Could you check your test, it seems to be failing on Travis.

scuml commented 3 years ago

Tests pass, but failure occurs on the swift_test_backtrace step - perhaps something wrong in Kitura/Package-Builder? Any ideas?

mbarnach commented 3 years ago

There is 2 failures in the test suite (see the end of the test command). They occurs in test_ZAddFloat. Could you have a look at it @scuml please? Thanks.

scuml commented 3 years ago

Thanks for pointing that out - didn't see those errors.

scuml commented 3 years ago

This should be passing now. Failure seems to be a timeout issue on Travis.

scuml commented 3 years ago

Comments added. Tests have been updated to test the new functionality.