search

Kitura / KituraKit

Swift client library for using Codable routes with Kitura
Apache License 2.0
59 stars 20 forks source link

Infinite loop #11

Closed sandmman closed 6 years ago

sandmman commented 6 years ago

Previously there was an infinite loop occurring in travis builds because ci/release.sh would push the updated version file back to tempMaster, which in turn triggered another build.

I have made a few changes that will fix this and hopefully make this more robust.

  1. When the version file is behind or the same as the latest tag, this automatically increments the latest tag's patch field.
  2. When the version file is ahead of the latest tag, the version in version file is used to create the new tag.
  3. The version file is updated to the current commit as before, but by putting "[skip ci]" in the commit message we can just skip the build. Skip Build Docs

This method allows users to ignore updating the version file unless they require an updated major or minor field; but also, if someone had manually added a tag this will sync the version file.

After making most of the changes, I realized that we could just skip the build, so you might decide the extra robustness is unnecessary. Either way, feel free to use my branch or any of the code. I'm sure some things could have been done cleaner/simpler.

DunnCoding commented 6 years ago

@sandmman Thanks for putting this together!