Kitura / KituraKit

Swift client library for using Codable routes with Kitura
Apache License 2.0
59 stars 20 forks source link

Decode RequestError body #18

Closed tunniclm closed 6 years ago

tunniclm commented 6 years ago

Add support for populating/decoding the body of a RequestError.

Requires: https://github.com/IBM-Swift/SwiftyRequest/pull/18

tunniclm commented 6 years ago

Waiting for Kitura to release a tagged version with the required router features for this to work.

codecov-io commented 6 years ago

Codecov Report

Merging #18 into master will increase coverage by 8.18%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   71.96%   80.15%   +8.18%     
==========================================
  Files           2        2              
  Lines         132      131       -1     
==========================================
+ Hits           95      105      +10     
+ Misses         37       26      -11
Flag Coverage Δ
#KituraKit 80.15% <80%> (+8.18%) :arrow_up:
Impacted Files Coverage Δ
Sources/KituraKit/Client.swift 83.33% <80%> (+7.3%) :arrow_up:
Sources/KituraKit/RequestErrorExtension.swift 45.45% <0%> (+18.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3b465f...169dc7c. Read the comment docs.

djones6 commented 6 years ago

Replaced by #30 as KituraKit's current release process requires we merge to develop not master.