search

Kitura / KituraKit

Swift client library for using Codable routes with Kitura
Apache License 2.0
59 stars 20 forks source link

Custom JSON encoder and decoder block properties #23

Closed tib closed 5 years ago

tib commented 6 years ago

In order to support the new custom JSONEncoder in Kitura it is required to introduce new customizable JSON encoder and decoder properties in KituraKit as well. See this PR.

codecov-io commented 6 years ago

Codecov Report

Merging #23 into master will decrease coverage by 2.11%. The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   71.96%   69.85%   -2.12%     
==========================================
  Files           2        2              
  Lines         132      136       +4     
==========================================
  Hits           95       95              
- Misses         37       41       +4
Flag Coverage Δ
#KituraKit 69.85% <68.42%> (-2.12%) :arrow_down:
Impacted Files Coverage Δ
Sources/KituraKit/Client.swift 73.59% <68.42%> (-2.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ce52cd...8e265f3. Read the comment docs.

djones6 commented 5 years ago

@tib Thank you for the effort that you put in to both this and the corresponding Kitura PR. The Kitura one was further developed into https://github.com/IBM-Swift/Kitura/pull/1221, and likewise @Andrew-Lees11 has developed the corresponding KituraKit change in #38 .

I'm closing this PR in favour of #38, which provides equivalent functionality but generalised for any media type.