Open fummicc1 opened 5 years ago
I agree that it would have been better to have an uppercase P, however this would be a breaking change. I'm not sure that we would want to break the API for the sake of correcting casing.
However, it might be possible to add an additional property idKeyPath
that essentially acts as an alias of idKeypath
. @kilnerm do you think this is feasible?
@djones6 Thankyou for your reply.
idKeypath
is not bad at all. But as for me, idKeyPath
is suitable because Swift's property is lowerCamelCase style!
Though I will comment #123 soon, #123 PR may be non-breaking. Please look at below Image.
Note: If my PR is passed, a part of README.md where idKeypath
is referred to should be change.
Suggestion. How about changing the variable name
idKeypath
?Nice to meet you, I recently started studying Kitura. Thank you for your daily maintenance! This is my personal opinion, but I would be happy if you could refer to it.
This is a quote from this site,
}
[ ] Actually happened (current way) ...