Kitura / Swift-Kuery-ORM

An ORM for Swift, built on Codable

Apache License 2.0

212 stars 30 forks source link

Renamed Model Property `idKeypath` into `idKeyPath`. #123

Open fummicc1 opened 5 years ago

fummicc1 commented 5 years ago

What is chagend

This PR changed property name Model.idKeypath -> Model.idKeyPath

reference issue

122

CLAassistant commented 5 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

djones6 commented 5 years ago

As per my comment in #122, I don't think we'd want to break the API in this way. Perhaps this could be done in an additive (non-breaking) way, such that either idKeyPath or idKeypath will work?

fummicc1 commented 5 years ago

About the danger of breaking the API, I just did build (⌘ + B) and confirmed that is succeeded.

This PR is very minimum change. so it might not be necessary! For your information!