search

Kitura / Swift-SMTP

Swift SMTP client
Apache License 2.0
260 stars 60 forks source link

Fixed issue with HTML attachments (501 Syntax error - line too long) #114

Closed sanzaru closed 3 years ago

sanzaru commented 3 years ago

The PR fixes an issue that occurred when trying to send long HTML attachments. The server then responded with an "501 Syntax error - line too long" error. I also fixed some closures.

Motivation and Context

I wanted to send some HTML mails and ran into the error, also it is subject of the following issue: https://github.com/Kitura/Swift-SMTP/issues/106

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

dannys42 commented 3 years ago

Would you mind rebasing to master?

sanzaru commented 3 years ago

Rebase done.

sanzaru commented 3 years ago

I fixed the tests. While running them, I found out that the line problem also occurs on data and html attachments. Should be also fixed now. All tests were successful, except TestTLSMode.testIgnoreTLS(), but that seems to be because of my server configuration, not because of the test.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

lmcd commented 3 years ago

Is this gonna be merged anytime soon?

dannys42 commented 3 years ago

Thanks @sanzaru and @mbarnach. I think there was some travis issue previously. I'm restarting the build.

dannys42 commented 3 years ago

I still need to look into what it'll take to get tests working again Issue 115 But I'll push this through in the mean time.