search

Kitura / Swift-SMTP

Swift SMTP client
Apache License 2.0
260 stars 60 forks source link

Fix a little RFC5321 syntax unconformance #117

Closed vitkabele closed 3 years ago

vitkabele commented 3 years ago

Description

I removed the additional spaces in two email commands

Motivation and Context

The description of the Mail transaction as provided in the RFC5321 does not specify a space after the MAIL FROM: and RCPT TO: commands.

How Has This Been Tested?

This changes were tested with an instance of the dovecot submission server, that previously refused the client commands.

Checklist:

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

vitkabele commented 3 years ago

Hello, I signed the CLA, you can now merge the PR

dannys42 commented 3 years ago

@vitkabele Thanks for the PR. Unfortunately I haven't gotten around to fixing these unit tests yet since they require test email accounts. But I'll go ahead and merge since @mbarnach gave the thumbs up and visual inspection seems good and straight forward enough. :-)