Finished conversion to Swift 4

Kitura / Swift-SMTP

Swift SMTP client

Apache License 2.0

259 stars 60 forks source link

Finished conversion to Swift 4 #57

Closed Davidde94 closed 6 years ago

Davidde94 commented 6 years ago

Conversion to Swift 4.0.3 has been finalised, with all warnings removed.

Motivation and Context

The warnings were irritating me across several projects.

How Has This Been Tested?

Using the already-existing test suite

Checklist:

[x] I have submitted a CLA form
[x] If applicable, I have updated the documentation accordingly.
[x] If applicable, I have added tests to cover my changes.

CLAassistant commented 6 years ago

All committers have signed the CLA.

quanvo87 commented 6 years ago

Great! I'll review and re-run Travis some time today. Travis build won't pass unless I do that. (We need to change this)

quanvo87 commented 6 years ago

Looking into how to get the Travis build working again.

ianpartridge commented 6 years ago

Hmm, still failing. @quanvo87 will try another tactic...

Davidde94 commented 6 years ago

@ianpartridge @quanvo87 you could always just take my word that it works? Who needs thorough testing, right?

quanvo87 commented 6 years ago

That's half the fun :)

quanvo87 commented 6 years ago

I've implemented a new dev ops flow. It is an improvement over the old one, but we still cannot get around the fact that Travis repo env vars are not available to forks (for good reason). So for now, I've pulled this PR into a PR of my own, #58. Tests pass because my PR is not a fork and Travis can access the repo env vars. I'll merge and provide credit to @Davidde94 in the release notes.

Future considerations for dev ops improvements could be:

changing the tests to not be end, but mock the smtp protocol instead
change any tests that are against a live smtp server to not run on forks, and when forks get merged, automatically trigger a build on the main repo (is this possible?)
others?

quanvo87 commented 6 years ago

https://github.com/IBM-Swift/Swift-SMTP/releases/tag/v2.0.0

ianpartridge commented 6 years ago

Thanks for doing this @quanvo87 !

Davidde94 commented 6 years ago

Thanks :)

ianpartridge commented 6 years ago

@quanvo87 re: others? Change unit tests to use a botnet spam relay, so no auth is required?