Kitware / CDash

An open source, web-based software testing server
http://www.cdash.org/
Other
218 stars 76 forks source link

`MallocGuardEdges` env var seems to interfere with OS detection #2581

Closed seanm closed 4 days ago

seanm commented 5 days ago

Consider this VTK build submission:

https://open.cdash.org/viewTest.php?onlynotrun&buildid=10040042

image

I enable the environment variable MallocGuardEdges to check for memory overruns when tests are run. (see man malloc on macOS). This causes a log message, for example:

% MallocGuardEdges=1 sw_vers
sw_vers(33753,0x202738f40) malloc: adding guard pages for large allocator blocks
ProductName:        macOS
ProductVersion:     14.7
BuildVersion:       23H124

versus without it:

% sw_vers
ProductName:        macOS
ProductVersion:     14.7
BuildVersion:       23H124

I believe this is why those 3 fields are scrambled. You should be able to look for ProductName then take the text after it.

williamjallen commented 5 days ago

As far as I am aware, this data comes directly from CTest, so this issue should probably be filed here.

seanm commented 5 days ago

Ah ok, it's not always clear to me where the lines are drawn. :)

seanm commented 4 days ago

https://gitlab.kitware.com/cmake/cmake/-/issues/26466

seanm commented 4 days ago

And once this is fixed in ctest, will cdash show the correct icon do you think?:

image
williamjallen commented 4 days ago

It should, yes. The icon is determined directly from the operating system data provided by CTest.