search

Kitware / DIVA

DIVA project repository
Other
18 stars 9 forks source link

Work around a bug with inner class parsing in g++ 4.8.5 #1

Closed collinsr closed 6 years ago

collinsr commented 6 years ago

g++ 4.8.5 (the default complier on centos7) has a bug:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59482

...which prevented the inner 'pimpl' classes for diva_geometry and diva_activity from compiling. This commit converts the pimpl classes from inner to peer classes.

Tested on both g++ 4.8.5 (centos7) and apple-clang 7.0.2 (osx).