search

Kitware / DIVA

DIVA project repository
Other
18 stars 9 forks source link

Dev/python3 #29

Closed as6520 closed 5 years ago

as6520 commented 5 years ago
  1. Support for python 3 using DIVA_PYTHON_ENABLE and DIVA_PYTHON_MAJOR_VERSION
  2. Changed the default python major version to 3.
  3. Minor refactor of diva_python_utils imports. Eg. from diva_python_utils import input is changed to from diva.utils import input
aaron-bray commented 5 years ago

LGTM!

johnhenning commented 5 years ago

Does the Dockerfile need to be updated with the new PR, or is the build process still the same?

as6520 commented 5 years ago

It is not necessary as DIVA_ENABLE_PYTHON and DIVA_PYTHON_MAJOR_VERSION are set to ON and 3 respectively. Although if you want to explicitly specify them in the Dockerfile, feel free to submit a PR.