Kitware / Danesfield-App

Web application for the Danesfield System
Apache License 2.0
32 stars 11 forks source link

Use cesium viewer to view 3D tiles in client #11

Closed mvandenburgh closed 3 years ago

mvandenburgh commented 3 years ago

Peek 2021-07-13 14-17

Note: a new girder plugin is used in this PR (girder-resource-path-tools), so you will need to rerun pip install server/ and girder build for it to work properly locally.

jjnesbitt commented 3 years ago

This looks good. I think the next step is to link this to a workingSet. It's a bit of a mess but this is what I think you should do in your local environment, to mimic the result of the workflow output:

Hopefully this makes sense. Let me know if you have any questions.

mvandenburgh commented 3 years ago

This looks good. I think the next step is to link this to a workingSet. It's a bit of a mess but this is what I think you should do in your local environment, to mimic the result of the workflow output:

I ran into an issue with the /workingSet/{id} endpoint returning a 401 because it requires authentication. Is authentication needed for this endpoint? I disabled it in https://github.com/Kitware/Danesfield-App/pull/11/commits/4b39857a9c0d897eefbd5519781e8740d608fc2f to get things working. Besides that, I followed your steps in my local environment and it looks like everything is working right.

jjnesbitt commented 3 years ago

I ran into an issue with the /workingSet/{id} endpoint returning a 401 because it requires authentication. Is authentication needed for this endpoint? I disabled it in 4b39857 to get things working. Besides that, I followed your steps in my local environment and it looks like everything is working right.

Sorry if this was unclear, I don't think there actually needs to be an endpoint for this action. In the workflow itself, it will set this value automatically, so on that side it's accomplished. Since you don't have the workflow yet, I was proposing setting this value through girder directly (with some script), and then just using it as normal.

jjnesbitt commented 3 years ago

Sorry if this was unclear, I don't think there actually needs to be an endpoint for this action. In the workflow itself, it will set this value automatically, so on that side it's accomplished. Since you don't have the workflow yet, I was proposing setting this value through girder directly (with some script), and then just using it as normal.

We talked offline. For posterity, @mvandenburgh was referring to a different endpoint, not the one he added. I was responding to the one he added. We figured out his issue with the other endpoint.