Fix bugs in run_danesfield.

Kitware / Danesfield

Kitware's system for 3D building reconstruction for the IARPA CORE3D program

Apache License 2.0

155 stars 56 forks source link

Fix bugs in run_danesfield. #18

Closed danlipsa closed 2 years ago

danlipsa commented 2 years ago

add the .png as texture file name
use node which is the name of the updated node interpreter. nodejs is the older program installed with npm.

danlipsa commented 2 years ago

@jacobderosa @dmjoy Please review.

dmjoy commented 2 years ago

LGTM apart from the one suggestion.

dmjoy commented 2 years ago

@jacobderosa here's the conflict (doesn't seem related to the line above as I initially thought):

<<<<<<< fix_run_danesfield
        cmd_args = ["node", "/3d-tiles-tools/tools/bin/3d-tiles-tools.js",
=======
        cmd_args = ["nodejs", "/3d-tiles-validator/tools/bin/3d-tiles-tools.js",
>>>>>>> master

danlipsa commented 2 years ago

@dmjoy I'll apply your suggestion and solve the conflict. I'll check what is the valid path - probably the one from master.

jacobderosa commented 2 years ago

I applied these changes in PR #19 @danlipsa @dmjoy