search

Kitware / HPCCloud

A Cloud/Web-Based Simulation Environment
https://kitware.github.io/HPCCloud/
Apache License 2.0
50 stars 23 forks source link

Simple replacement of pvpython with pvbatch. #503

Closed chetnieter closed 7 years ago

chetnieter commented 8 years ago

Did the straight-forward and perhaps naive replacement of pvpython with pvbatch.

codecov-io commented 8 years ago

Current coverage is 61.80% (diff: 100%)

Merging #503 into master will not change coverage

@@             master       #503   diff @@
==========================================
  Files            59         59          
  Lines          2788       2788          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1723       1723          
  Misses         1065       1065          
  Partials          0          0

Powered by Codecov. Last update 99ea1e8...38d4238

jourdain commented 8 years ago

Look good, but the main questions remain (probably because I'm not aware): 1) Does pvbatch work with ParaViewWeb? 2) Did we push a fix in ParaView code base so it will be part of 5.2 release?

chetnieter commented 8 years ago

@jourdain Those recent commit was just me rebasing on master so I can start working on this again. I still haven't worked out what is going on yet but hopefully next week I will at least be really to come to you with questions.

jourdain commented 8 years ago

Sounds great. Thanks!

cjh1 commented 7 years ago

@TristanWright @chetnieter Can idea why this wasn't merged?

TristanWright commented 7 years ago

I glanced at this yesterday and had the same question

chetnieter commented 7 years ago

It must have slipped through the cracks. I know I was waiting for changes to paraview that I worked with Seb and Utkarsh on that were needed before we merged but those were added to paraview sometime ago. As far as I know this can be merged after the conflicts are resolved.

TristanWright commented 7 years ago

closed in favor of #596