Kitware / HPCCloud

A Cloud/Web-Based Simulation Environment
https://kitware.github.io/HPCCloud/
Apache License 2.0
50 stars 23 forks source link

Remove old taskflows #512

Closed TristanWright closed 8 years ago

TristanWright commented 8 years ago

addresses #238, does not look at taskflow statuses when deleting as discussed on that issue

codecov-io commented 8 years ago

Current coverage is 61.21% (diff: 86.66%)

Merging #512 into release will increase coverage by 0.72%

@@            release       #512   diff @@
==========================================
  Files            59         59          
  Lines          2918       2939    +21   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1765       1799    +34   
+ Misses         1153       1140    -13   
  Partials          0          0          

Powered by Codecov. Last update 5f130c7...047c8bd

TristanWright commented 8 years ago

Yes I must have commit -a, I'll discard it

On Wed, Sep 14, 2016 at 2:44 PM, Chet Nieter notifications@github.com wrote:

@chetnieter commented on this pull request.

In src/redux/README.md https://github.com/Kitware/HPCCloud/pull/512:

@@ -42,6 +42,12 @@ [_id]: { }, } },

  • volumes: {
  • mapById: { volumes... },
  • clusterMapById: {
  • },
  • }, statuses: {

This might have gotten slipped in when Tristan was talking about the volume work and react/redux while we were at KHQ.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Kitware/HPCCloud/pull/512, or mute the thread https://github.com/notifications/unsubscribe-auth/AMs36al1iOE1gY0DEfFuur2VotAR7qdtks5qqFyngaJpZM4J5H9z .

R&D Engineer Kitware Inc.

cjh1 commented 8 years ago

@TristanWright Is this not something we could add a test for?

TristanWright commented 8 years ago

Yes, I would like to. Earlier I was having trouble setting the state for a action test (as opposed to a reducer test) it was definitely something I wanted to look into again.

TristanWright commented 8 years ago

Updated with tests for the delete functionality.

cjh1 commented 8 years ago

@TristanWright I like the new spinner on the terminate button, one question though, why does it disappear before the taskflow is terminated?