search

Kitware / HPCCloud

A Cloud/Web-Based Simulation Environment
https://kitware.github.io/HPCCloud/
Apache License 2.0
50 stars 23 forks source link

updated kw-web-suite #583

Closed TristanWright closed 7 years ago

TristanWright commented 7 years ago

Lots of changes all syntactic

jourdain commented 7 years ago

We should see if we can remove also some old rules with the 0. We can look at what we exclude in ParaViewWeb, vtk-js in case we want to keep things consistent across projects. But if we manage to have less, it is always better.

jourdain commented 7 years ago

So you can override them when bringing visualizer. The same apply for ParaViewWeb.

On Tue, Jan 31, 2017 at 3:29 PM, TristanWright notifications@github.com wrote:

@TristanWright commented on this pull request.

In package.json https://github.com/Kitware/HPCCloud/pull/583:

@@ -15,7 +15,16 @@ "dependencies": { "commander": "2.9.0", "open": "0.0.5",

  • "shelljs": "0.5.3"
  • "shelljs": "0.5.3",
  • "react": "15.3.0",
  • "react-dom": "15.3.0",
  • "react-router": "2.0.1",
  • "redux": "3.3.1",
  • "react-redux": "4.4.1",
  • "react-router-redux": "4.0.0",
  • "reselect": "2.5.3",
  • "mout": "0.11.1" }, "devDependencies": { "ws": "0.8.1",

Yeah there are some build issues. Why aren't they dependencies on the visualizer package?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Kitware/HPCCloud/pull/583, or mute the thread https://github.com/notifications/unsubscribe-auth/AAR-dsCAgfSrYrGgjiGXdeuqH3bHvUGlks5rX7XGgaJpZM4LyBua .

TristanWright commented 7 years ago

Ran it with the latest eslint packages and it's just some import ordering and default prop definitions, I'm going to leave it out for now.

import/first react/require-default-props

jourdain commented 7 years ago

sounds good to me. Thanks for taking care of it...

codecov-io commented 7 years ago

Codecov Report

Merging #583 into master will increase coverage by 0.06%.

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   61.77%   61.84%   +0.06%     
==========================================
  Files          61       61              
  Lines        2891     2891              
==========================================
+ Hits         1786     1788       +2     
+ Misses       1105     1103       -2
Impacted Files Coverage Δ
src/redux/reducers/aws.js 61.22% <ø> (ø) :white_check_mark:
src/network/helpers/projects.js 16% <ø> (ø) :white_check_mark:
src/redux/reducers/clusters.js 64.74% <ø> (ø) :white_check_mark:
src/redux/reducers/taskflows.js 35.71% <ø> (ø) :white_check_mark:
src/redux/reducers/network.js 83.95% <ø> (ø) :white_check_mark:
src/panels/ButtonBar/index.js 83.33% <ø> (ø) :white_check_mark:
src/network/remote/system.js 20% <ø> (ø) :white_check_mark:
src/panels/JobMonitor/LogFold.js 92.3% <ø> (ø) :white_check_mark:
src/network/helpers/simulations.js 19.48% <ø> (ø) :white_check_mark:
src/network/remote/utils.js 31.81% <ø> (ø) :white_check_mark:
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cccacff...8824043. Read the comment docs.

TristanWright commented 7 years ago

This is ready to merge