search

Kitware / HPCCloud

A Cloud/Web-Based Simulation Environment
https://kitware.github.io/HPCCloud/
Apache License 2.0
50 stars 23 forks source link

Rename update method to prevent override #603

Closed cjh1 closed 7 years ago

cjh1 commented 7 years ago

The use of the update(...) signature was unintentional overriding the implementation provided by girder.models.model_base.Model. This cause problems when deleting groups which relies on this base class implementation.

cjh1 commented 7 years ago

@TristanWright This should fix up the issue you where seeing yesterday.

codecov-io commented 7 years ago

Codecov Report

Merging #603 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #603   +/-   ##
=======================================
  Coverage   62.03%   62.03%           
=======================================
  Files          61       61           
  Lines        2845     2845           
=======================================
  Hits         1765     1765           
  Misses       1080     1080

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 018da07...f50a9e0. Read the comment docs.

TristanWright commented 7 years ago

I didn't know you could override methods like that, lgtm