Kitware / HPCCloud

A Cloud/Web-Based Simulation Environment

https://kitware.github.io/HPCCloud/

Apache License 2.0

50 stars 23 forks source link

Migrate plugins to Girder 3 api. #627

Closed aronhelser closed 5 years ago

aronhelser commented 5 years ago

api and other migration changes, required by Girder 3.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1565901). Click here to learn what that means. The diff coverage is 25%.

@@            Coverage Diff            @@
##             master     #627   +/-   ##
=========================================
  Coverage          ?   57.12%           
=========================================
  Files             ?      135           
  Lines             ?     6202           
  Branches          ?        0           
=========================================
  Hits              ?     3543           
  Misses            ?     2659           
  Partials          ?        0

Impacted Files	Coverage Δ
src/network/remote/file.js	`9.58% <25%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1565901...bdfb8df. Read the comment docs.

aronhelser commented 5 years ago

getting this failure I'm not sure how to address: @cjh1 do you have any suggestions?

StateTransitionBehavior ✓ does nothing if there's no taskflow 08 07 2019 16:37:45.773:WARN [web-server]: 404: /api/v1/simulations/574c8aa00640fd3f1a3b379f fs actions depending on taskflow state ✗ does not update folders if not all complete Error: spy was not supposed to be called at assert (test/contexts/tests.all.js:8130:9) at Expectation.toNotHaveBeenCalled (test/contexts/tests.all.js:7737:28) at UserContext. (test/contexts/tests.all.js:125576:52) at

cjh1 commented 5 years ago

@aronhelser I am not familiar with these tests @jourdain may be able to help, but it looks like "does not update folders if not all complete" is no longer true, may be a change in a redux actions. These tests are client side only, so shouldn't be effected by the server changes.

aronhelser commented 5 years ago

OK, I think I'm going to disable the test and proceed....

On Tue, Jul 9, 2019 at 8:19 AM Chris Harris notifications@github.com wrote:

@aronhelser https://github.com/aronhelser I am not familiar with these tests @jourdain https://github.com/jourdain may be able to help, but it looks like "does not update folders if not all complete" is no longer true, may be a change in a redux actions. These tests are client side only, so shouldn't be effected by the server changes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Kitware/HPCCloud/pull/627?email_source=notifications&email_token=AEX6THIBH6UVZ3MEHDNNVA3P6R66RA5CNFSM4H475VO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZQCZAY#issuecomment-509619331, or mute the thread https://github.com/notifications/unsubscribe-auth/AEX6THL6QV4Z3ME6HXSRVN3P6R66RANCNFSM4H475VOQ .

cjh1 commented 5 years ago

Good plan.

aronhelser commented 5 years ago

Disabling the test worked here. @cjh1 a second for review....

aronhelser commented 5 years ago

@cjh1 OK to merge?

cjh1 commented 5 years ago

@aronhelser Yes, sorry for the delay.

aronhelser commented 5 years ago

I think you have to hit the button @cjh1 I don't have write permission.

cjh1 commented 5 years ago

@aronhelser I can fix that

cjh1 commented 5 years ago

@aronhelser Try now

aronhelser commented 5 years ago

Thanks! Might be good to add Scott W. to HPCCloud as well...

cjh1 commented 5 years ago

Done