Kitware / KWStyle

Kitware Style Checker
Other
53 stars 30 forks source link

KWStyle boost is 1.60 (2015-12-17), an update might fix ITK dashboard warnings #74

Closed seanm closed 5 years ago

seanm commented 6 years ago

My ITK dashboards have warnings from KWSys's boost, ex:

https://open.cdash.org/viewBuildError.php?type=1&buildid=5269390

[CTest: warning suppressed] /Users/builder/external/ITK-AppleClang-dbg-x86_64-ASanUBSan/KWStyle/Utilities/boost/smart_ptr/bad_weak_ptr.hpp:43:39: warning: dynamic exception specifications are deprecated [-Wdeprecated-dynamic-exception-spec]
    virtual char const * what() const throw()
                                      ^~~~~~~

Perhaps/hopefully a newer boost would fix this.

thewtex commented 6 years ago

@seanm has this been addressed by #75 ?

seanm commented 6 years ago

Alas no.

Also: I realize I made a typo above: we're talking KWStyle, not KWSys. :)

Is there a mechanism for the ITK dashboards to ignore warnings from 3rd party code? I guess this is off topic for a KWStyle ticket, but...

thewtex commented 6 years ago

Ok, thanks for the effort, and for checking.

Yes, we can have CDash ignore the warnings by adding a regex here:

https://github.com/InsightSoftwareConsortium/ITK/blob/8bae9edf6506575b5f30a4660ef766183e46f024/CMake/CTestCustom.cmake.in#L58

seanm commented 6 years ago

hmmm, it already has:

  ".*KWStyle/Utilities.*"

so I guess I've misinterpreted cdash's output, and the 2 warnings in that link aren't the KWStyle ones at all...

seanm commented 6 years ago

I'm confused... on the cdash summary page, there's a "1" in the warning column for this build:

https://open.cdash.org/viewBuildError.php?type=1&buildid=5285460

what's the 1 warning? Everything seems to be "warning suppressed" and from KWStyle...

thewtex commented 6 years ago

Nothing jumps out. If you build it locally, is there any warnings from KWStyle itself?

seanm commented 6 years ago

I can try once master is building again...

thewtex commented 5 years ago

Boost updated to 1.67 in #79 -- closing. Please re-open or create a new issue if the problem still exists.