COMP: Set the minimum required CMake version to 3.10.2.

Kitware / KWStyle

Kitware Style Checker

Other

53 stars 30 forks source link

COMP: Set the minimum required CMake version to 3.10.2. #78

Closed jhlegarreta closed 4 years ago

jhlegarreta commented 6 years ago

As agreed in: https://discourse.itk.org/t/cmake-update/870/

Set the cmake_minimum_required to version 3.10.2.

jhlegarreta commented 6 years ago

I think the IMMEDIATE option for the CONFIGURE_FILE command was removed as of CMake 3.x so I'd appreciate a review from the knowledgeable people before merging this. Thanks.

It's present here and here.

jhlegarreta commented 6 years ago

@bradking @thewtex @cryos The travis CI build failed because it is running a 3.9.2 CMake version. Can the travis CI CMake be updated to match the required version if this topics is to be merged? Thanks !

thewtex commented 5 years ago

@jhlegarreta Thanks for the contribution!

The following could get this branch green:

Rebase on master to resolve merge conflicts.
Add osx_image: xcode10.1 to .travis.yml may upgrade CMake to a sufficient version as suggested in the TravisCI C++ docs.

jhlegarreta commented 5 years ago

Done in ba4021c.

thewtex commented 5 years ago

:-( looks like it did not work.

Maybe brew install cmake?

jhlegarreta commented 5 years ago

Looks like brew is not being recognized as a command 🙄

hjmjohnson commented 4 years ago

Superceeded by #92

jhlegarreta commented 4 years ago

Thanks @hjmjohnson ! Closing.