search

Kitware / KWStyle

Kitware Style Checker
Other
53 stars 30 forks source link

COMP: Type not C-compatible due to non-POD member #94

Closed hjmjohnson closed 4 years ago

hjmjohnson commented 4 years ago

KWStyle/kwsParser.h:127 col 5: note: type is given name 'Error' for linkage purposes by this typedef declaration KWStyle/kwsParser.h:136 col 5: note: type is given name 'Warning' for linkage purposes by this typedef declaration KWStyle/kwsParser.h:151 col 5: note: type is given name 'IndentPosition' for linkage purposes by this typedef declaration

warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage]

note: type is not C-compatible due to this member declaration

hjmjohnson commented 4 years ago

@thewtex This is needed to cleanly build KWStyle with clang11. It is a real (obscure, but real) issue due to potential (very unlikely in our case) linkage issues.

I would like to update the download hash in ITK to get the latest KWSTyle binaries.

hjmjohnson commented 4 years ago

@dzenanz Could you please give this a quick review and merge?

dzenanz commented 4 years ago

@bradking Can you merge and/or give me write access?