BUG: Copy FindHoloPlayCore into VTK build tree

Kitware / LookingGlassVTKModule

Other

15 stars 12 forks source link

BUG: Copy FindHoloPlayCore into VTK build tree #15

Closed aylward closed 2 years ago

aylward commented 3 years ago

Problem: FindHoloPlayCore.cmake is not exposed in the VTK build tree, so any application built against a VTK build tree that is build with LookingGlass Rendering enabled will have to have its own copy of FindHoloPlayCore.cmake

Solution: Place FindHoloPlayCore in the VTK_BINARY_DIR/vtk_cmake_destination directory during configuration so that applications that build against the VTK build tree can automatically discover it.

aylward commented 3 years ago

@cquammen @jcfr - any concerns with this?

cquammen commented 3 years ago

Should be fine - I'll shout if it breaks ParaView somehow.

aylward commented 3 years ago

@cquammen - can you please merge this? I don't have write permission :(

cquammen commented 3 years ago

Sure, after @jcfr has a say.

jcfr commented 3 years ago

As a short term workaround, this makes sense.

Moving forward, we should:

add a HoloPlayCoreConfig.cmake file to the zip file distributed by LookingGlass
improve VTK build system

aylward commented 2 years ago

@cquammen - please merge - JCFR provided feedback.