Kitware / LookingGlassVTKModule

Other
15 stars 12 forks source link

Update Looking Glass Core #52

Closed psavery closed 1 year ago

psavery commented 2 years ago

This updates Looking Glass Core to the latest version, which also supports arm64 wheels on Mac, so they are being added as well.

psavery commented 2 years ago

To give an update on this PR, there are a few issues that need to be fixed:

psavery commented 2 years ago

I was able to fix the issue with the render window not being placed properly on Mac via 7c4fc2d4d166c5945df7cab27f8aa1bd091c0d47. So that is good news.

Looking Glass will hopefully be rebuilding the Linux SDK soon with an older version of GLIBC, which will fix one of the other issues.

I was not able to fix the cross-compiling issues. They seem to be difficult issues to solve, and I think the best course of action right now is to not build the arm64 wheels in the CI, wait until GitHub Actions provides arm64 runners (so that we do not have to perform cross-compilation), and build arm64 wheels manually on a local machine until the arm64 runners are out. Building the arm64 wheels manually and pushing to PyPI is not very difficult, and we can easily do it for releases.

psavery commented 2 years ago

For now, we have downgraded the SDK that Linux uses so that wheels may be built. We don't know for sure if the older SDK on Linux will work with the new Looking Glass Bridge service, but we are unfortunately unable to test it. Worst case scenario for Linux would be that the users would have to use the older HoloPlayService.

Anyways, everything is building now, and this PR is ready for review.