Open bpaniagua opened 1 year ago
The new pipeline creator is a good candidate for this. The (unmerged) new pipeline creator plus the work in this commit can make a module that does initial-fit + refinement. The batch processing part of the new pipeline infrastructure has not been started however.
- Generate a module that does batch fits of s-reps
@allemangD @HarryDC
Going to use this issue to expand on this part. Batch fitting needs to run two modules:
1) SRepCreator: Given an input surface and some parameters generates an initial s-rep 2) SRepRefiner: Given an input surface and the initial s-rep generated by 1), improves the fit
The initial stitching of those two together should be in the commit that Connor linked above, the missing piece is just the batch processing.
Yea I looked at the two pipelines, i think those are good to go, I have the creator in a state too where it can potentially store multiple output paramters/nodes. And we are ready to create a pipeline from the two parts.
I can put up a SlicerSalt branch that has the connors branch in SRep and my pipelines working branch tied together, i'll set up a combined pipeline so that all the parameters are exposed in the Creator/Refiner pipeline, you should then be able to create a .csv with all the input nodes and input parameters and run that through the Creator/Refiner
@vicory Where should the created combined module live ? Checked into SREP as a module or as something under SlicerSALT ?
Hi Harry, The new module should live under s-reps.
Quick update, it took a bit of hand editing (the annotations that limit the inputs and confer the defaults aren't copied by the pipeline creator) but this is the Combined Module.
The list of parameters is long as I exposed all the parameters of both the generation and the refinement pipelines
I'll push updates Slicer/SRep/Pipenline branches so you can test this