Closed kevinsmia1939 closed 3 years ago
Hi @mleotta It has been sometime. I hope you are doing well.
It just occurred to me that I can just ship the binary instead of building from source. I package TeleSculptor binary as Flatpak and it works on my machine.
I have to build ICU 60, because most distro use newer version now.
Flatpak run TeleSculptor-1.1.2-Linux-x86_64.sh and automatically answer yes to the license agreement. Any person who install TeleSculptor with Flatpak will not see this agreement.
From what I see, the extracted files does not have License file(?), I will copy the LICENSE from the source instead and put it somewhere manually, where do you want it to be? (/bin /share /lib ...) Would this be acceptable?
TeleSculptor does not have .desktop and .metainfo is that right? If so I will create them.
Do I need to install numpy and pybind11 as well? Or does this binary already bundled them?
Please let me know what you think.
The install command is basically this.
- chmod +x TeleSculptor-1.1.2-Linux-x86_64.sh
- yes | ./TeleSculptor-1.1.2-Linux-x86_64.sh
- cd TeleSculptor-1.1.2-Linux-x86_64 && cp -r {bin,lib,share} /app
Thanks.
Also, will you update Qt soon? I see that it still use 5.11, but it reach the eol already. Edit: NVM, I can see that it is being worked on https://github.com/Kitware/fletch/pull/639
I have some problem. I am not sure what happen, but the directory choose dialog does not work for me. The file chooser dialog popup when I click "New Project". It show "Open" button, but it just open folder, does not choose them, I was unable to choose any folder.
Could this be because TeleSculptor use Qt 5.11?
If installing from binary is acceptable for Flatpak then I have no objections.
Yes, it seems the license file is not installed, so not in the package, we could add it if that is a standard thing to package. I assume it would go under share/telesculptor/[version]
. Likewise we don't have .desktop
and .metainfo
files. I'm not sure what goes in them and where they would get installed. It sounds like we should add them.
We are working on updating Qt to 5.12 as well as various other improvements that will go into TeleSculptor v1.2.0. I'm hoping to get that out soon, but waiting on corresponding Fletch and Kwiver releases.
I'm not sure about that file dialog issue. What OS are you on? We probably need to do more UI testing across different Linux distros.
@borovik135, you've been using the UI on Linux recently. Have you had this issue creating a new project?
If installing from binary is acceptable for Flatpak then I have no objections.
Yes, it seems the license file is not installed, so not in the package, we could add it if that is a standard thing to package. I assume it would go under
share/telesculptor/[version]
. Likewise we don't have.desktop
and.metainfo
files. I'm not sure what goes in them and where they would get installed. It sounds like we should add them.We are working on updating Qt to 5.12 as well as various other improvements that will go into TeleSculptor v1.2.0. I'm hoping to get that out soon, but waiting on corresponding Fletch and Kwiver releases.
I'm not sure about that file dialog issue. What OS are you on? We probably need to do more UI testing across different Linux distros.
@borovik135, you've been using the UI on Linux recently. Have you had this issue creating a new project?
Thanks for reply, I create .desktop and metainfo.xml file already, I will be submitting it to you soon.
I use openSUSE Tumbleweed KDE. About the UI thing. My guess is that the upstream binary use Qt 5.11. But when using binary inside Flatpak, it use portal to Qt 5.15, which might cause some compatibility issue.
I think I will just wait until TeleSculptor update to Qt 5.12, and use KDE Sdk 5.12 so it would be easier to figured out.
When trying to build TeleSculptor without Fletch I am able to get up to this point, where I am missing kwiver::kwiver_adapter, kwiver::kwiver_algo_qt_widgets. I am quite sure Boost contains everything it should because Kwiver detects it. Any suggestions what might me missing?
CMake Error at /usr/local/lib/cmake/kwiver/utils/kwiver-utils-targets.cmake:182 (add_executable):
Target "TeleSculptor" links to target "kwiver::kwiver_adapter" but the
target was not found. Perhaps a find_package() call is missing for an
IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
gui/CMakeLists.txt:150 (kwiver_add_executable)
CMake Error at /usr/local/lib/cmake/kwiver/utils/kwiver-utils-targets.cmake:182 (add_executable):
Target "TeleSculptor" links to target "kwiver::kwiver_algo_qt_widgets" but
the target was not found. Perhaps a find_package() call is missing for an
IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
gui/CMakeLists.txt:150 (kwiver_add_executable)
CMake Error at /usr/local/lib/cmake/kwiver/utils/kwiver-utils-targets.cmake:182 (add_executable):
Target "TeleSculptor" links to target "Boost::chrono" but the target was
not found. Perhaps a find_package() call is missing for an IMPORTED
target, or an ALIAS target is missing?
Call Stack (most recent call first):
gui/CMakeLists.txt:150 (kwiver_add_executable)
CMake Error at /usr/local/lib/cmake/kwiver/utils/kwiver-utils-targets.cmake:182 (add_executable):
Target "TeleSculptor" links to target "Boost::system" but the target was
not found. Perhaps a find_package() call is missing for an IMPORTED
target, or an ALIAS target is missing?
Call Stack (most recent call first):
gui/CMakeLists.txt:150 (kwiver_add_executable)
CMake Error at /usr/local/lib/cmake/kwiver/utils/kwiver-utils-targets.cmake:182 (add_executable):
Target "TeleSculptor" links to target "kwiver::kwiver_algo_vtk" but the
target was not found. Perhaps a find_package() call is missing for an
IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
gui/CMakeLists.txt:150 (kwiver_add_executable)
cmake .. -DCMAKE_BUILD_TYPE:STRING=Release -DKWIVER_ENABLE_SPROKIT=ON -DKWIVER_ENABLE_C_BINDINGS=ON -DKWIVER_ENABLE_TOOLS=ON -DKWIVER_ENABLE_PYTHON=OFF -DKWIVER_ENABLE_ARROWS=ON
-- Current path: '/home/skinkie/Sources/kwiver/CMake'
-- Import CMake future from '/home/skinkie/Sources/kwiver/CMake/future'
-- Import CMake future '3.10'
-- Performing Test has_compiler_flag--Werror=return-type
-- Performing Test has_compiler_flag--Werror=return-type - Success
-- Performing Test has_compiler_flag--Werror=non-virtual-dtor
-- Performing Test has_compiler_flag--Werror=non-virtual-dtor - Success
-- Performing Test has_compiler_flag--Werror=narrowing
-- Performing Test has_compiler_flag--Werror=narrowing - Success
-- Performing Test has_compiler_flag--Werror=init-self
-- Performing Test has_compiler_flag--Werror=init-self - Success
-- Performing Test has_compiler_flag--Werror=reorder
-- Performing Test has_compiler_flag--Werror=reorder - Success
-- Performing Test has_compiler_flag--Werror=overloaded-virtual
-- Performing Test has_compiler_flag--Werror=overloaded-virtual - Success
-- Performing Test has_compiler_flag--Werror=cast-qual
-- Performing Test has_compiler_flag--Werror=cast-qual - Success
-- Performing Test has_compiler_flag--Werror=vla
-- Performing Test has_compiler_flag--Werror=vla - Success
-- Performing Test has_compiler_flag--Wshadow=local
-- Performing Test has_compiler_flag--Wshadow=local - Success
-- checking CPP_AUTO auto.cxx
-- checking CPP_CONSTEXPR constexpr.cxx
-- checking CPP_DEFAULT_CTOR default-ctor.cxx
-- checking CPP_FINAL final.cxx
-- checking CPP_NOEXCEPT throw-noexcept.cxx
-- checking CPP_RANGE_FOR range-for.cxx
-- checking STD_CHRONO std_chrono.cxx
-- checking STD_NULLPTR null_ptr.cxx
-- checking STD_REGEX std_regex.cxx
-- Making library "kwiver_algo_core"
-- Building plugin "kwiver_algo_core"
-- Making library "kwiver_algo_core_plugin"
-- Making library "kwiver_algo_core_applets"
-- Making library "kwiver_algo_mvg"
-- Building plugin "kwiver_algo_mvg"
-- Making library "kwiver_algo_mvg_plugin"
-- Making library "kwiver_algo_mvg_applets"
-- Making library "kwiver_algo_klv"
-- Making library "sprokit_pipeline"
-- Making library "sprokit_pipeline_util"
-- Making library "sprokit_applets"
-- Making library "processes_clusters"
-- Making library "processes_examples"
-- Making library "schedulers"
-- Making library "schedulers_examples"
CMake Deprecation Warning at vital/kwiversys/CMakeLists.txt:78 (CMAKE_MINIMUM_REQUIRED):
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
-- Making library "vital"
-- Making library "vital_exceptions"
-- Making library "vital_algo"
-- Making library "algo_explorer_plugin"
-- Making library "vital_util"
-- Making library "vital_c"
-- Making library "vital_config"
-- Making library "format_config"
-- Making library "vital_logger"
-- Making library "vital_vpm"
-- Making library "kwiver_tools_applet"
-- Making library "vital_applets"
-- Making library "explorer_plugin"
-- [configure-ceres_bundle_adjuster] Creating configure command
-- [configure-core_feature_descriptor_io] Creating configure command
-- [configure-core_feature_tracker] Creating configure command
-- [configure-core_fmatrix_guided_feature_matcher] Creating configure command
-- [configure-core_homography_guided_feature_matcher] Creating configure command
-- [configure-core_image_list_video_input] Creating configure command
-- [configure-core_nonmax_detector] Creating configure command
-- [configure-core_output_homography_generator] Creating configure command
-- [configure-core_pca_canonical_tfm] Creating configure command
-- [configure-core_track_filter] Creating configure command
-- [configure-core_video_input_image_list] Creating configure command
-- [configure-core_video_input_image_pos_list] Creating configure command
-- [configure-cuda_integrate_depth_maps] Creating configure command
-- [configure-default_camera_intrinsics] Creating configure command
-- [configure-ffmpeg_video_input] Creating configure command
-- [configure-loop_closer_bad_frames] Creating configure command
-- [configure-loop_closer_homography] Creating configure command
-- [configure-loop_closer_keyframe] Creating configure command
-- [configure-loop_closer_multi_method] Creating configure command
-- [configure-mvg_hierarchical_bundle_adjuster] Creating configure command
-- [configure-mvg_initialize_cameras_landmarks] Creating configure command
-- [configure-mvg_initialize_cameras_landmarks_basic] Creating configure command
-- [configure-ocv_klt_tracker] Creating configure command
-- [configure-ocv_ORB_detector_descriptor] Creating configure command
-- [configure-ocv_SURF_detector_descriptor] Creating configure command
-- [configure-super3d_depth_map] Creating configure command
-- [configure-applet-dump_klv] Creating configure command
-- [configure-applet-estimate_depth] Creating configure command
-- [configure-applet-fuse_depth] Creating configure command
-- [configure-applet-init_cameras_landmarks] Creating configure command
-- [configure-applet-track_features] Creating configure command
-- [configure-applet-color_mesh] Creating configure command
-- [configure-models-default_burnout_600_iters] Creating configure command
-- [configure-pipelines-detect_burnin] Creating configure command
-- [configure-pipelines-inpaint_burnin] Creating configure command
-- [configure-version.h] Creating configure command
-- Configuring done
-- Generating done
-- Build files have been written to: /home/skinkie/Sources/kwiver/build
Hi, I'm here to report that the new TeleSculptor works now, I can choose the folder properly now. I will update the Flatpak for testing soon.
I submit pr to flathub here, waiting to be build and test. https://github.com/flathub/flathub/pull/2525
@mleotta Hi, Does TeleSculptor need network connection? I create .desktop and metainfo.xml file for TeleSculptor, I want to submit this patch, which directory where do you want it to?
@kevinsmia1939 I would suggest putting those files in packaging
since that is where we have been putting file that are need to support packaging TeleSculptor. TeleSculptor does not need a network connect after it is built and installed.
I create TeleSculptor Flatpak!
This is a test repo, but it can be install like this.
I guess this can be close now. It is here: https://flathub.org/apps/details/org.telesculptor.TeleSculptor
Hello,
I am trying to build Telesculptor for Linux Flatpak.
I got the error below. I build Kwiver 1.5.1 with cmake with the flags,
Build qtExtensions master branch with cmake with default flag. https://github.com/Kitware/qtextensions Build VTK 9.0.1 with cmake with these flags,
And finally Telesculptor 1.1.1 with Cmake.
Could this issue be relate to this? https://github.com/Kitware/kwiver/issues/517
I got this error.