search

Kitware / UPennContrast

UPenn ?
https://upenn-contrast.netlify.com/
Apache License 2.0
8 stars 6 forks source link

Repeated use of SAM lead to slowdown #706

Open arjunrajlab opened 2 months ago

arjunrajlab commented 2 months ago

Someone from lab noticed that while using SAM, the page starts to become slower and slower. At some point it may even crash. A page refresh seems to solve the issue. The issue seems to arise the longer you use SAM. We aren't sure if the issue is from the use of SAM specifically or just adding a large number of annotations one by one, but it has definitely show up with SAM. The issue is there whether you turn the SAM tool on and off or not, so it's probably not the encoder or anything like that.

Seems to occur once 100 annotations or so have been added/30 minutes of use.

bruyeret commented 2 months ago

I created around 120 annotations with the SAM tool on the same page but I didn't notice anything I have some questions:

Also is it "~100 annotations and 30 minutes" or "~100 annotations or 30 minutes"?

bruyeret commented 2 months ago

Is it easy to reproduce ? If so, can the user share what happens in the console ?

arjunrajlab commented 2 months ago

I think it was ~100 annotations AND 30 minutes or so. I think it was a lot of vertices, but probably not simplification of zero. I think there was probably a lot of encoding and moving around the screen, but I will check. I'm not sure about manual blobs. I'll ask him to reproduce and show me the console!

arjunrajlab commented 2 months ago

From someone in lab: "I am using simplification at 0, I am definitely encoding more than 10 times to create that number of annotations (probably more in the realm of 30 times), and it's 100 annotations in about 30 minutes. Worth noting as well that I'm switching rapidly between times while making the annotations to watch the colonies forming, I feel like that could be a part of it."