Kitware / UPennContrast

UPenn ?
https://upenn-contrast.netlify.com/
Apache License 2.0
8 stars 6 forks source link

Remove repeat words #723

Closed arjunrajlab closed 1 month ago

arjunrajlab commented 1 month ago

Removes repeated words in property autonaming to avoid "blob Blob blob" things from happening.

arjunrajlab commented 1 month ago

Ah yes, that's how I did it at first, until I realized it doesn't work :)…

image

The problem is that the tokens are actually not words. If you join "YFP blob" and "Blob metrics", it doesn't know they are repeated. So actually the simplest thing was to just let it join it and then re-split. Is there a way to undo the commit? Although yes, we should remove the //annotationNames thing.

bruyeret commented 1 month ago

Oh ok yes, I'll revert the changes, sorry for the mistake!