search

Kitware / candela

Visualization components for the web
https://candela.readthedocs.io
Apache License 2.0
116 stars 29 forks source link

Fix autoresize problem in VegaCharts #476

Closed waxlamp closed 7 years ago

waxlamp commented 7 years ago

Vega has a way to update the width and height of a chart on render, without recompiling from the spec. VegaChart now takes advantage of it, restoring the AutoResize functionality in the demos.

codecov-io commented 7 years ago

Codecov Report

Merging #476 into master will decrease coverage by -0.17%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   40.66%   40.49%   -0.17%     
==========================================
  Files          36       36              
  Lines        1237     1242       +5     
==========================================
  Hits          503      503              
- Misses        734      739       +5
Impacted Files Coverage Δ
VisComponent/mixin/VegaChart.js 22.22% <ø> (-8.55%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b4a891...03908a1. Read the comment docs.