Closed waxlamp closed 7 years ago
Merging #485 into master will increase coverage by
0.12%
. The diff coverage is50%
.
@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 33.99% 34.11% +0.12%
==========================================
Files 38 39 +1
Lines 1518 1530 +12
==========================================
+ Hits 516 522 +6
- Misses 1002 1008 +6
Impacted Files | Coverage Δ | |
---|---|---|
components/index.js | 100% <100%> (ø) |
:arrow_up: |
components/SentenTree/index.js | 45.45% <45.45%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cbc653f...65695cf. Read the comment docs.
Can you add a screenshot if it's easy? I'm curious what this thing is.
🍛
@mgrauer, sure thing, screencap added to top comment.
Rebased on master.
@ronichoudhury this. is. cool.
Looks like this has conflicts now, probably pretty simple to rebase.
Rebased.
Looking good. I discovered that you are not emptying the div
before rendering the component. Could you add that in?
Oops. Added in a new commit.
It might be worthwhile to put some of this stuff (emptying top-level div, prepping datasets with column selectors) into helper functions. I'll file an issue to that effect.
Is it better to leave it as integer
and fix upstream, or change it to number
so that it works now?
Since this is not on a critical path, I'd say leave as integer and support it as needed in downstream tools.
Depends on #483 for proper CI.