search

Kitware / candela

Visualization components for the web
https://candela.readthedocs.io
Apache License 2.0
116 stars 29 forks source link

Swallow errors from `npm run semantic-release` #486

Closed waxlamp closed 7 years ago

waxlamp commented 7 years ago

This is done because technically, semantic-release fails with non-zero exit code on ENOCHANGE, which is the error code generated when there is nothing to actually release (i.e., if there are no feat or fix commit tags).

Travis gets around this by not failing the entire build if the after_success step fails; in Circle we're using the deployment step for this, which does fail the whole build if it fails.

codecov-io commented 7 years ago

Codecov Report

Merging #486 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   39.15%   39.15%           
=======================================
  Files          37       37           
  Lines        1300     1300           
=======================================
  Hits          509      509           
  Misses        791      791

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f61310...4101271. Read the comment docs.