search

Kitware / candela

Visualization components for the web
https://candela.readthedocs.io
Apache License 2.0
116 stars 29 forks source link

fix(UpSet): Update UpSet to not pollute global namespace #492

Closed jeffbaumes closed 7 years ago

jeffbaumes commented 7 years ago

The branch https://github.com/jeffbaumes/upset/tree/no-global-vars creates a new concatenated index.js for UpSet that does not use the script loader so does not pollute the global namespace with lots of variables.

codecov-io commented 7 years ago

Codecov Report

Merging #492 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   34.11%   34.11%           
=======================================
  Files          39       39           
  Lines        1530     1530           
=======================================
  Hits          522      522           
  Misses       1008     1008

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9db9c6f...760b204. Read the comment docs.