Kitware / candela

Visualization components for the web
https://candela.readthedocs.io
Apache License 2.0
116 stars 29 forks source link

refactor(vega): Move to Vega 3.0, VegaLite 2.0 #509

Closed jeffbaumes closed 7 years ago

jeffbaumes commented 7 years ago
codecov-io commented 7 years ago

Codecov Report

Merging #509 into master will decrease coverage by 7.24%. The diff coverage is 43.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   47.72%   40.47%   -7.25%     
==========================================
  Files          62       58       -4     
  Lines        1645     1465     -180     
==========================================
- Hits          785      593     -192     
- Misses        860      872      +12
Impacted Files Coverage Δ
plugins/vega/index.js 100% <ø> (ø) :arrow_up:
plugins/vega/BarChart/index.js 92.85% <100%> (+17.85%) :arrow_up:
plugins/mixin/index.js 100% <100%> (ø) :arrow_up:
plugins/vega/ScatterPlot/index.js 18.18% <11.11%> (-56.82%) :arrow_down:
plugins/vega/ScatterPlotMatrix/index.js 20% <12.5%> (-55%) :arrow_down:
plugins/vega/GanttChart/index.js 40% <33.33%> (-35%) :arrow_down:
plugins/vega/BoxPlot/index.js 9.52% <5.26%> (-65.48%) :arrow_down:
plugins/vega/LineChart/index.js 11.11% <6.25%> (-19.66%) :arrow_down:
plugins/mixin/VegaView.js 69.23% <69.23%> (ø)
plugins/vega/Histogram/index.js 13.33% <7.69%> (-61.67%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a3c04e...375e66b. Read the comment docs.

jeffbaumes commented 7 years ago

@ronichoudhury ready for review.

waxlamp commented 7 years ago

There are still a few "regressions" (not reflected in the tests) caused by this PR, but I think we should merge this now and fix the issues in future topics. Here's a list:

waxlamp commented 7 years ago

@jeffbaumes since you're away, I'll press the button. Hope you don't mind :)