search

Kitware / candela

Visualization components for the web
https://candela.readthedocs.io
Apache License 2.0
116 stars 29 forks source link

feat(LineChart): Add option for setting x and y scales #516

Closed jeffbaumes closed 7 years ago

jeffbaumes commented 7 years ago

Fixes #512

jeffbaumes commented 7 years ago

@ronichoudhury take a look. I've added a way to set scale options, that way you can set nice and zero to false, which makes the dynamic line plot look much nicer.

codecov-io commented 7 years ago

Codecov Report

Merging #516 into master will decrease coverage by 0.11%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   40.47%   40.36%   -0.12%     
==========================================
  Files          58       58              
  Lines        1465     1469       +4     
==========================================
  Hits          593      593              
- Misses        872      876       +4
Impacted Files Coverage Δ
plugins/vega/LineChart/index.js 9.09% <0%> (-2.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5eb48f...b97a702. Read the comment docs.

waxlamp commented 7 years ago

Fantastic!