search

Kitware / candela

Visualization components for the web
https://candela.readthedocs.io
Apache License 2.0
116 stars 29 forks source link

fix(build): Fixes broken build by ensuring new vega-canvas is not depended on #528

Closed jeffbaumes closed 6 years ago

jeffbaumes commented 6 years ago

Fixes #527

@ronichoudhury PTAL

waxlamp commented 6 years ago

Also, Jeff authorized me to merge this in his stead -- doing so... now.

jbeezley commented 6 years ago

This isn't working for me as is for some reason. Starting from a new directory and a bare package.json, when I run npm install candela I get:

$ npm ls vega
npm@1.0.0 /home/jbeezley/tmp/npm
└─┬ candela@0.18.1
  ├── vega@3.0.10 
  └─┬ vega-tooltip@0.4.4
    └── vega@3.0.10  deduped
$ node --version
v7.10.0
$ npm --version
5.6.0

Any ideas?

jeffbaumes commented 6 years ago

I believe the issue is that some candela tests are failing so it was not auto-published to npm by CI. The following should pull in the right versions (but does not have dist stuff so in general won't work).

npm i git+https://github.com/Kitware/candela

I think we need to get a candela release out. Ideas @ronichoudhury ?

jbeezley commented 6 years ago

Oh right. I didn't even check if a new release was out.