Kitware / candela

Visualization components for the web

https://candela.readthedocs.io

Apache License 2.0

116 stars 29 forks source link

Revert "fix(build): Fixes broken build by ensuring new vega-canvas is not depended on" #532

Closed jeffbaumes closed 6 years ago

jeffbaumes commented 6 years ago

This reverts commit 46a97fcd8a84b10fdb00c73e2f6194a5a4c1582b since https://github.com/vega/vega-canvas/issues/1 is resolved and a new vega-canvas was released.

jeffbaumes commented 6 years ago

I realized something is slightly wrong here. package-lock.json is not updated on this branch and probably should be. Can anyone direct me in the correct way to update/generate package-lock.json based on the one that is already in master?

jbeezley commented 6 years ago

npm install will update it as necessary. Alternatively if you want to regenerate it completely for some reason, you can run npm install after deleting it.

jeffbaumes commented 6 years ago

Ok I think I did it correctly - ready for review.

codecov-io commented 6 years ago

Codecov Report

Merging #532 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #532   +/-   ##
=======================================
  Coverage   40.03%   40.03%           
=======================================
  Files          61       61           
  Lines        1506     1506           
=======================================
  Hits          603      603           
  Misses        903      903

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0422b5b...e4a8252. Read the comment docs.