search

Kitware / candela

Visualization components for the web
https://candela.readthedocs.io
Apache License 2.0
116 stars 29 forks source link

fix(vega): Remove unneeded deps to avoid version/interaction issues #540

Closed jeffbaumes closed 6 years ago

jeffbaumes commented 6 years ago

Without this, some incompatible versions of vega-* libraries were pulled in, causing interaction to break.

jeffbaumes commented 6 years ago

@waxlamp ok this PR turned into a no-op. It seems that doing the following fixed things up for me. Please verify and I'll close this one.

lerna clean
rm -rf ./node_modules
rm package-lock.json

npm install
npm run build
npm run build:examples
npm run examples
waxlamp commented 6 years ago

This sequence worked for me -- I have an interactive scatter plot again.

jeffbaumes commented 6 years ago

There is still a slight bit of mystery because the published @candela/all v0.21.0 still appears to have the non-interaction issue. There might be some tweaking needed in circle's yaml? For example, when does the "npm install" step happen there? Or maybe the problem will just "go away" on the next version?

waxlamp commented 6 years ago

@jeffbaumes, do you think this is still a problem? If there's a way to reproduce it, could you open an issue describing how to do so?

jeffbaumes commented 6 years ago

This problem seems to have gone away in the latest release, so this is totally resolved from my point of view. I'll delete this branch.