search

Kitware / candela

Visualization components for the web
https://candela.readthedocs.io
Apache License 2.0
116 stars 29 forks source link

Include babel-loader in all test configurations #546

Closed waxlamp closed 6 years ago

jeffbaumes commented 6 years ago

What's the context of this change, what problem does it solve?

waxlamp commented 6 years ago

There's no evident problem that it solves; for some reason, without this loader the tests seem to build properly, but for completeness I wanted to include the loader rule.

waxlamp commented 6 years ago

@jeffbaumes could you take another look at this please (made the change I discussed with your yesterday, which caused your earlier approval to be dismissed).

jeffbaumes commented 6 years ago

Circle is complaining with:

TypeError: Class constructor ScatterPlot cannot be invoked without 'new' FAILED

Is there something different about the transpilation that is affecting this?

waxlamp commented 6 years ago

I rebased this branch on master to properly incorporate the build improvements there--and if this doesn't just work, I'm inclined to drop this PR.

waxlamp commented 6 years ago

@jeffbaumes, looks like the problem is fixed now.