Kitware / cumulus

A REST API for creating and using cloud clusters
Apache License 2.0
27 stars 9 forks source link

Create volumes #297

Closed TristanWright closed 7 years ago

cjh1 commented 7 years ago

@TristanWright This is ready for testing now

cjh1 commented 7 years ago

@TristanWright OK, this has reinstate my commits. I have tested this. I noticed that when the volume log appears, its name is 'new volume' not the name assigned to the volume.

TristanWright commented 7 years ago

I noticed that too on mine, but I was actually naming the volume "new volume" looking into it.

On Thu, May 25, 2017 at 12:15 PM, Chris Harris notifications@github.com wrote:

@TristanWright https://github.com/tristanwright OK, this has reinstate my commits. I have tested this. I noticed that when the volume log appears, its name is 'new volume' not the name assigned to the volume.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Kitware/cumulus/pull/297#issuecomment-304083079, or mute the thread https://github.com/notifications/unsubscribe-auth/AMs36TmMytHLgIWTfshdEBrki6PXyN8dks5r9cVHgaJpZM4LPkEt .

--

R&D Engineer Kitware Inc.

cjh1 commented 7 years ago

@TristanWright Can we fix up these failing tests?

TristanWright commented 7 years ago

Tests fixed :)

cjh1 commented 7 years ago

I am running into the following error when trying to visualize the results of a run:

[15:13:26.736] ERROR: Exception raise by task.
  File "/usr/local/lib/python2.7/dist-packages/celery/app/trace.py", line 240, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/celery/app/trace.py", line 438, in __protected_call__
    return self.run(*args, **kwargs)
  File "cumulus/taskflow/__init__.py", line 117, in wrapped
    return func(celery_task, *args, **kwargs)
  File "/opt/hpccloud/hpccloud/server/taskflows/hpccloud/taskflow/paraview/visualizer.py", line 281, in monitor_paraview_job
    monitor_job.s(cluster, job, girder_token=girder_token))
  File "cumulus/taskflow/__init__.py", line 198, in run_task
    }, **options)
  File "/usr/local/lib/python2.7/dist-packages/celery/canvas.py", line 251, in apply_async
    return _apply(args, kwargs, **options)
  File "/usr/local/lib/python2.7/dist-packages/celery/app/task.py", line 565, in apply_async
    **dict(self._get_exec_options(), **options)
  File "/usr/local/lib/python2.7/dist-packages/celery/app/base.py", line 354, in send_task
    reply_to=reply_to or self.oid, **options
  File "/usr/local/lib/python2.7/dist-packages/celery/app/amqp.py", line 305, in publish_task
    **kwargs
  File "/usr/local/lib/python2.7/dist-packages/kombu/messaging.py", line 172, in publish
    routing_key, mandatory, immediate, exchange, declare)
  File "/usr/local/lib/python2.7/dist-packages/kombu/connection.py", line 449, in _ensured
    return fun(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/kombu/messaging.py", line 188, in _publish
    mandatory=mandatory, immediate=immediate,
  File "/usr/local/lib/python2.7/dist-packages/amqp/channel.py", line 2123, in _basic_publish
    self._send_method((60, 40), args, msg)
  File "/usr/local/lib/python2.7/dist-packages/amqp/abstract_channel.py", line 56, in _send_method
    self.channel_id, method_sig, args, content,
  File "/usr/local/lib/python2.7/dist-packages/amqp/method_framing.py", line 219, in write_method
    properties = content._serialize_properties()
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 499, in _serialize_properties
    getattr(raw_bytes, 'write_' + proptype)(val)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 350, in write_table
    table_data.write_item(v, k)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 382, in write_item
    self.write_table(v)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 350, in write_table
    table_data.write_item(v, k)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 382, in write_item
    self.write_table(v)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 350, in write_table
    table_data.write_item(v, k)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 382, in write_item
    self.write_table(v)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 350, in write_table
    table_data.write_item(v, k)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 382, in write_item
    self.write_table(v)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 350, in write_table
    table_data.write_item(v, k)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 382, in write_item
    self.write_table(v)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 350, in write_table
    table_data.write_item(v, k)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 385, in write_item
    self.write_array(v)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 396, in write_array
    array_data.write_item(v)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 382, in write_item
    self.write_table(v)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 350, in write_table
    table_data.write_item(v, k)
  File "/usr/local/lib/python2.7/dist-packages/amqp/serialization.py", line 366, in write_item
    self.write(pack('>ci', b'I', v))
error: 'i' format requires -2147483648 <= number <= 2147483647

Not sure its related to these changes but I want to get to the bottom of it before I merge.

cjh1 commented 7 years ago

I am going to try to recreate with a simple paraviewweb workflow.

TristanWright commented 7 years ago

Wow I've never seen an error like that, esp. from the visualization workflow

TristanWright commented 7 years ago

Wow I've never seen an error like that, especially from the visualization workflow

cjh1 commented 7 years ago

@TristanWright Can you do a file test of a paraviewweb workflow. Then we will merge this.

TristanWright commented 7 years ago

I can run all the way through, but getting unable to connect ws:// errors.

Error during WebSocket handshake: Unexpected response code: 503

I've definitely run into these before, fiddled with the address in the cumulus config without luck. @jourdain is there something new in pvw-visualizer we need to be using (currently at 2.0.18)?

jourdain commented 7 years ago

It might just be an issue on your dev settings.

TristanWright commented 7 years ago

No errors otherwise, should we merge?

cjh1 commented 7 years ago

Yes, let merge it

TristanWright commented 7 years ago

Just need an approval, the hpccloud branch is already approved.