search

Kitware / cumulus

A REST API for creating and using cloud clusters
Apache License 2.0
27 stars 9 forks source link

Cluster terminate messages are not displayed in cluster log #317

Open TristanWright opened 7 years ago

TristanWright commented 7 years ago

Moved from HPCCloud #597

Been looking at the cluster_log_url and it's

http://localhost:9999/api/v1/clusters/59497ecf0640fd17c3a5fbdf/log

That would be the localhost of the machine right though? The line %s/clusters/%s/log appears a few places and we're passing different base URL's to it.

cjh1 commented 7 years ago

@TristanWright That is the problem. 9999 is the port for the dev server not girder I think. I would guess in this can the third option is being used. We can't rely on getApiUrl(). We should be using cumulus.config.girder.baseUrl ro the girder_api_url from the taskflow object.

TristanWright commented 7 years ago

I think I have a fix, culprit was getApiUrl here. Should the other uses of getApiUrl be swapped with cumulus.config.girder.baseUrl?

What I'm a bit curious about is why the URLs stopped working too?

cjh1 commented 7 years ago

@TristanWright Yes, we should not be using getApiUrl(...) for urls that end up being calling from with a celery worker. It would be good to clean these up. Its possible that this worked in the pass it everything was running on the same machine or the hostname inside and outside the VM where the same, not sure :man_shrugging:

TristanWright commented 7 years ago

I cleaned them up in 1da84ba035c1f350acaf95e069655ee5b282a9e5 and fixed tests with them

getApiUrl is in three other files

None of these should be called from the celery worker right?

cjh1 commented 7 years ago

@TristanWright These should be changed as well.