search

Kitware / cumulus

A REST API for creating and using cloud clusters
Apache License 2.0
27 stars 9 forks source link

Migrate to girder 3.x #347

Closed psavery closed 5 years ago

psavery commented 5 years ago

I can load all of the plugins so far. But I think the tests need some work.

psavery commented 5 years ago

@cjh1 I've gotten the Travis-CI down to only one failing test.

The migration guide mentions that models are no longer automatically registered, and that models must be explicitly registered before loading them via a string. They recommend putting the model registration in the load() method of the GirderPlugin class.

From what I can tell, this typically works fine for the girder plugins. However, for the source code of cumulus (not the plugin, but the code in cumulus/cumulus), I am unsure of how to get a model registered. This is a problem for the failing test here (the error starts here on travis-ci), because it complains that the model isn't registered.

Because girder 3.x uses setuptools to install girder plugins, I know we could probably import the model directly like from cumulus_plugin.models.aws import Aws as AwsModel, but I am not sure if we want to import code from the plugins into the cumulus source code.

psavery commented 5 years ago

All the tests pass now. I think it is ready for some runtime tests.

psavery commented 5 years ago

@cjh1 The tests pass here and on mongochemserver. I am also able to run all of the calculations in the mongochemdeploy notebooks using girder3, this branch, the mongochemserver branch, and the mongochemdeploy branch.

I think these are ready for review, starting with this one.