search

Kitware / diva-v1-annotation-issues

Issue board for corrections and comments relating to the annotations for the IARPA DIVA V1 dataset
4 stars 0 forks source link

Timestamps are zero-based; frame filenames are one-based. #4

Open collinsr opened 6 years ago

collinsr commented 6 years ago

The TS0 fields start at zero; the filenames start numbering at one.

collinsr commented 6 years ago

Personally speaking, I think of "frame number" as "index from start of dataset". In a situation where the data source is a stream or live source (without a global reference for zero), my instinct would be to call the first frame pulled from the source "TS0: 0", the next "TS1: 1", etc.

That said, it's annoying in V1 to have to add one to the TS0 field to get to the filename.

There are three possible resolutions:

  1. Do nothing; TS0 and the filename are off by one. (Status quo.)
  2. Shift all the TS0 fields up by one so that TS0 and the filenames match. (We could do this via an annotation file update.)
  3. Renumber the frame files down by one so that TS0 and the filenames match. This is listed for completeness' sake; such a change would have to be implemented at each site with a copy of the frames, and the risk of one site updating and another not and thus having '00004.png' contain different pixels is (to my mind) too high.

What do folks think? Is (1) enough of a problem that we should implement (2)? Or would this disrupt things too much?

hamadrana99 commented 6 years ago

I think it's a little too late to fix this because we manually addressed this in our codes and if you change it now, we would have to fix a lot of our code. So let's just let it go for now. It's not too big of an issue.