Kitware / dive

Media annotation and analysis tools for web and desktop. Get started at https://viame.kitware.com
https://kitware.github.io/dive
Apache License 2.0
79 stars 21 forks source link

Not able to load annotations after viame >= 0.20 #1397

Open ltetrel opened 7 months ago

ltetrel commented 7 months ago

Describe the bug

Loading annotation is not working correctly after 0.20. It works when loading dataset < 0.20, then open >= 0.20 and load from Recent section.

Error occurred in handler for 'finalize-import': Error: Images were provided in an unexpected order and dataset contains multi-frame tracks.
    at /opt/viame_0.20.3/dive/resources/app.asar/background.js:2:1591647
    at internal/streams/pipeline.js:99:7
    at internal/util.js:392:14
    at o.<anonymous> (internal/streams/pipeline.js:35:5)
    at o.<anonymous> (internal/util.js:392:14)
    at onfinish (internal/streams/end-of-stream.js:56:29)
    at o.emit (events.js:327:22)
    at finishMaybe (_stream_writable.js:639:14)
    at endWritable (_stream_writable.js:656:3)
    at o.Writable.end (_stream_writable.js:595:5)

image

To Reproduce Steps to reproduce the behavior:

  1. Download release Linux Full Desktop Binaries v0.20.3 from there.
  2. Launch dive with launch_dive_interface.sh.
  3. Try to import a new image sequence with annotation viame csv format

Related data annotations_subsample.csv

Expected behavior Shoud correctly load after > 0.20

Desktop (please complete the following information):

BryonLewis commented 7 months ago

When loading the annotations, are the only images in the image-sequence loading into the following: frame000787.png frame000788.png frame000789.png frame000790.png

Are there extra images in the dataset that aren't accounted for which may make the frame order off?

I'm linking this PR for my own reference into what could be causing this problem: #1344

ltetrel commented 7 months ago

In the annotation file, there are some frames that does not include any annotations if that is your question. Will ping you when the data upload is done.

BryonLewis commented 7 months ago

I downloaded and tested with the latest version. Looks like I already fixed this months ago but didn't cut a release (other work was priority):

1386

I could replicate the issue on the default 1.9.4 release. I just completely forgot about doing this fix at the time.

BryonLewis commented 6 months ago

Should hopefully be closed in #1400