search

Kitware / dive

Media annotation and analysis tools for web and desktop. Get started at https://viame.kitware.com
https://kitware.github.io/dive
Apache License 2.0
82 stars 21 forks source link

[FEATURE] If saved box already exists and drawing a poly for it, don't decrease box size #693

Open mattdawkins opened 3 years ago

mattdawkins commented 3 years ago

Uncertain about if this change should be made vs addressing it in other ways, but the background is when I was drawing polygons for detections (which already had a premade box) I was frequently running into issues with polygon creation was ending earlier than I wanted and the polygon would be created, and then a new box on the bounds of that polygon destroying the originally (good) boxes I had drawn and replacing it with a bad box.

I think that if the polygon exceeds the original box size it should redraw the box though not if it's smaller than the original box size. The better solution might be to not have situations where my polygon drawing was ending prematurely than I wanted, but that might be harder to get right.

waxlamp commented 2 years ago

@mattdawkins could you give us a more precise repro here? Specifically, do you know how you can get the polygon drawing to end prematurely?