search

Kitware / fletch

Computer Vision Software Development Environment
63 stars 54 forks source link

Clean up Dockerfile #737

Closed daniel-riehm closed 1 year ago

daniel-riehm commented 1 year ago

This PR cleans up the Dockerfile, which has not been building properly for a long while. Notable changes include removal of the PY_MAJOR_VERSION argument (python2 is long deprecated) and the neat COPY --from=base / / trick which reduces the size of the resulting container dramatically (20GB -> 3GB) by removing the layers describing the changes to intermediate build files, keeping only the installed final product.

daniel-riehm commented 1 year ago

Looks good to me. Do we know if this will impact the Kitware docker image?

https://github.com/Kitware/kwiver/blob/master/Dockerfile

If not we should check and prepare a MR for the KWIVER Dockerfile to insure it still builds.

Yes, I have a cleanup branch for KWIVER as well, but was waiting for this one to merge before creating a MR for it.