search

Kitware / fletch

Computer Vision Software Development Environment
63 stars 54 forks source link

Update cppzmq #760

Closed johnkit closed 4 months ago

johnkit commented 5 months ago

Updates cppzmq to add option for a later release (4.10.0), which includes many API improvements. The previous version (4.2.3) is still the default.

Note: this supersedes #738 closes #738

johnkit commented 5 months ago

@dstoup Can you review this PR please? I don't seem to have permission to add you (or anyone) to the "Reviewers" section; so I would appreciate if you would also do that.

chetnieter commented 4 months ago

@johnkit could we get this PR modified so it adds the new version of cppzmq as an option rather than replacing the old version. You can look at what is done for OpenCV to see how fletch supports multiple versions. I am not sure how this will impact the KWIVER 2.0 work and because things are in flux it is hard to test it right now. Once we determine that the new version of cppzmq works with the KWIVER 2.0 changes we can drop the older version, but for now I would like to keep it.

johnkit commented 4 months ago

@chetnieter it appears that mac build failed and windows build still pending (?). Can you get more details from Jenkins?

chetnieter commented 4 months ago

@chetnieter it appears that mac build failed and windows build still pending (?). Can you get more details from Jenkins?

I am not worried about the Mac build. We have effectively dropped support for that awhile. Once the windows build run I will mrege.

chetnieter commented 4 months ago

jenkins test this please