Kitware / gobig

Provisioning big data applications with Resonant
Apache License 2.0
5 stars 3 forks source link

switch upstart role to using multilog #44

Closed opadron closed 8 years ago

opadron commented 8 years ago

Switches upstart role so that all generated services log their output through the multilog tool from the daemon-tools package instead of directly to disk. The multilog tool handles rotating logs and limiting log size, so we should no longer be running into megabyte- and gigabyte-size logs.

A side-effect of this change is that markers for service startup and termination are no longer inserted into the log output.

opadron commented 8 years ago

Hey, @kotfic, could you QA this? It should be a quick one and would be nice to have.

kotfic commented 8 years ago

Sorry for long delay on review of this - I am not super familiar with multilog/daemontools. It looks like a primarily debian/ubuntu thing? At the very least this should probably ensure that multilog is installed. A default VM of ubuntu 14.04 doesn't come with daemontools installed.

opadron commented 8 years ago

multilog comes with the daemontools package. I don't think it's specific to Debian.

kotfic commented 8 years ago

sure, lets just make sure there is an apt call that insures daemontools is installed.

opadron commented 8 years ago

resolved via #61