search

Kitware / gobig

Provisioning big data applications with Resonant
Apache License 2.0
5 stars 3 forks source link

Girder rework #49

Open kotfic opened 8 years ago

kotfic commented 8 years ago

This branch

  1. cleans out romanesco, climos and sparktest configs
  2. removes the girder-post-install role which does specific girder configurations
  3. updates the install process to use girder-install web
  4. installs nodejs following the girder docs

It relies on the following two mongo related pull requests being merged:

  1. Tweaks configs to get working standalone mongodb
  2. MongoDB Rework

With those, the following playbook installs a baseline functioning install of girder

- name: Deploy mongodb                                                                                                                                         
  hosts: mongo                                                                                                                                                 
  become: yes                                                                                                                                                  
  roles:                                                                                                                                                       
    - role: mongodb                                                                                                                                            
      state: started                                                                                                                                           

- name: Deploy girder                                                                                                                                          
  hosts: girder                                                                                                                                                
  become: yes                                                                                                                                                  
  roles:                                                                                                                                                       
    - role: girder                                                                                                                                             
      mongodb_ansible_group: mongo                                                                                                                             
      state: started
opadron commented 8 years ago

@kotfic The mongodb commits in this PR should be superseded by #43. Can you rebase and include only the girder changes?

kotfic commented 8 years ago

@opadron I thought there were comments on the nodejs approach taken here? Am I just going crazy?

opadron commented 8 years ago

@kotfic Looks like an outdated diff.

kotfic commented 8 years ago

@opadron cool, thought i was nuts.

In terms of the node_js role, i'm concerned about the current implementation, it requires setting the node_binary and npm_binary variables in order to run, this is done currently by including the nodejs roles, but the npm/node binary variables are only used in the girder roles. It would be nice to decouple those - what if i added {npm,node}_binary variables to girder-variables role. If they are set we use those and set a new variable girder_install_nodejs to false. If they are not set we use default system locations and then set girder_install_nodejs to true

opadron commented 8 years ago

What about just setting the variables to where the nodesource binary package installs them? (/usr/bin/node, or wherever they end up going) Then, the logic is only in place and all the roles that need nodejs just need to use the variables.