Closed oeway closed 4 years ago
@oeway awesome! Thank you! :1st_place_medal:
Beautiful ideas, and I love the implementation :heart:
Two requests:
1) Please add comments over getStore
, getViewProxy
, and the UserInterface
export along the lines of
/ The
Store
is considered an internal implementation detail and its interface and behavior may change without changes to the major version. /
Since these will likely change as we add Zarr, categorical color, etc. support, and we do not want it to be unexpected that they will change. :-)
2) Please do a rebase, squash fix-up commits, and add commitizen conventional changelog prefixes to the commit subject line (see other commits in the repository for examples). When creating commits in the future, npm run commit
to commit can help walk through the prefixes and format. A brief reference is here:
This is used to generate our Release Notes and the Zenodo Citation Notes.
@thewtex Glad that you liked it. Thank you for your tips, and I just made a squash. Please take a look and let me know if you want me to change anything.
@oeway thanks!
Could feat[utils]
please be updated to feat(utils)
?
Sure, just did it, sorry about that.
Thanks!
:tada: This PR is included in version 9.17.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Not sure how you would do this, but with this PR, I am trying to extract utility functions and export it such that it will be much easier to customize the viewer.
For now,
itkVtkViewer.utils
has:readFiles
for reading files into VTK imageconvertItkToVtkImage
for converting user data into a VTK imageUserInterface
for customize the user interface, for example recreate the MainUI in another containier outside the viewer.With these extracted functions and additions to existing api, I would like to:
utils.readFiles
convertItkToVtkImage
getStore
.And I think we can add more in the future.
Please let me know if you have better idea.