WIP: Replace lut pwf select with tabs

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js

https://kitware.github.io/itk-vtk-viewer/

BSD 3-Clause "New" or "Revised" License

210 stars 64 forks source link

WIP: Replace lut pwf select with tabs #249

Closed scottwittenburg closed 4 years ago

scottwittenburg commented 4 years ago

This is coming along. Still needed:

[x] Better styling of tabs
[x] text of labels better contrast
[x] Improve look/feel of visibility checkboxes
[x] Hook up component visibility to volume rendering
[ ] with 2 components, second one doesn't seem to be registered until you click the tab
[x] if only one component, don't show the tabs (and don't allow turning that comp off)

scottwittenburg commented 4 years ago

@thewtex More work to do here, but the faked tabs don't look too bad given that they're actually radio buttons ;-), and the checkboxes actually work to turn on/off the contributions of the various components, but only for the slices.

scottwittenburg commented 4 years ago

@thewtex This could go in now if you like, and I can create a new issue for the remaining unchecked item in the description. I'm struggling to figure out why we see the behavior, and it could make sense as a separate bug anyway.

scottwittenburg commented 4 years ago

@thewtex I fixed the color/contrast on the selected tab as we discussed earlier today, and I think I addressed all the issues you raised in review here. Thanks for providing feedback!